[Serverless] Fix truncation in breadcrumbs #171770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dosant
commented
Nov 22, 2023
| @@ -62,6 +62,17 @@ const getHeaderCss = ({ size }: EuiThemeComputed) => ({ | |||
| top: 2px; | |||
| `, | |||
| }, | |||
| leftHeaderSection: css` | |||
| // needed to enable breadcrumbs truncation | |||
| min-width: 0; | |||
There was a problem hiding this comment.
Dosant
changed the title
Dosant
added
release_note:skip
|
Pinging @elastic/appex-sharedux (Team:SharedUX) |
💛 Build succeeded, but was flaky
Failed CI Steps
Metrics [docs]Async chunks
Page load bundle
HistoryTo update your PR or re-run it, just comment with: |
eokoneyo
reviewed
Nov 23, 2023
There was a problem hiding this comment.
Whilst I'd hoped we wouldn't have this component accept props that are presentational, I think this specific use case highlights that it's current implementation will at some point run into limitations.
Well done @Dosant! Tested locally, changes LGTM;
eokoneyo
approved these changes
Nov 23, 2023
kibanamachine
added
v8.12.0
backport:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix truncation in breadcrumbs when the header doesn't fit: https://css-tricks.com/flexbox-truncated-text/
I noticed this issue while working on #170758
(look at breadcrumbs)
Screen.Recording.2023-11-22.at.17.26.35.mov
Note: the root breadcrumb will be fixed with EUI update elastic/eui#7375